fix prepend ptr when sequence num. changes #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequence number changed i.e. due to race condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of multiple threads handling multiple packets it might happen that the sequence number of a paket changes before it got send out. In that case the checksum for that packet needs to be recalculated and the new sequence number must be added to the tcp header.
When this is done, the size of the TCP Header will be removed from the available headspace and length twice for a packet which later on results in an assertion because the prepend_ptr will be smaller then the start_ptr.
This is fixed by adding the header size before hitting the continue statement of the for loop.