Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve App details image duplications #289

Conversation

ss-nikunj
Copy link
Contributor

@ss-nikunj ss-nikunj commented Aug 28, 2024

Description

  • The user uploads one image on the App details page while registering the app but it ended up showing the same image 3 times. Since max 3 images can be uploaded, the system somehow repeats the image thrice.
  • One single image repeat thrice on the Validate & Publish screen as well as on the App overview page.

Why

  • Image should display only once on both the Validate & Publish screen as well as on the App overview page.

Issue

  • Shared Component: #288
  • Portal Frontend: #1031

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

image

@ss-nikunj ss-nikunj requested review from lavanya-bmw and oyo and removed request for lavanya-bmw August 28, 2024 13:10
Copy link

@ss-nikunj ss-nikunj marked this pull request as draft August 29, 2024 05:43
@ss-nikunj ss-nikunj closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

1 participant