Setversion updaterange on major version change #4790
Conversation
|
@phermsdorf you need to sign the ECA for this to be able to be accepted. |
|
I've renewed my ECA. Please trigger the build again ... |
|
The check still fails: https://api.eclipse.org/git/eca/status/gh/eclipse-tycho/tycho/4790 did you use the correct mail address? Is your account connected to the github username? |
Test Results 618 files 618 suites 4h 32m 20s ⏱️ For more details on these failures, see this check. Results for commit 5697e20. ♻️ This comment has been updated with latest results. |
|
I've it connected to my github account but maybe my new email address is causing this problem .... i'll check .... |
|
please try again ... |
Works now thanks! |
There was a problem hiding this comment.
The testcase looks sane and shows the problem already by a failing test. @phermsdorf can you squash both commits into one so this can easier be cherry picked to different branches?
phermsdorf
force-pushed
the
setversion_updaterange_on_major_version_change
branch
from
abf6001 to
5697e20
Compare
|
Sorry @laeubi for asking, but do you have any ETA when this issue might be fixed? Otherwise i would need to start using the current version and adjust the unusable ranges manually .... Thanks, bye Peter |
|
@phermsdorf I try to look into this in the next days. |
|
@phermsdorf the feature of updating major version ranges itself is now merged in Tycho but without the option for automatic manifest generation. If you like, you can rebase your branch and transform it into a test-case where automatic manifest generation is used so we probably pick that up later. as a new feature |
Followup on the issue described in discussion #4788 .
This PR adds an integration test demonstrating the described issue.
Please adjust as you see fit.
Thanks for looking into the problem.
bye Peter