Skip to content

Move Eclipse platform dependencies to parent pom dependency management#5409

Open
Copilot wants to merge 1 commit intomainfrom
copilot/fix-9e75fa8d-7996-4484-86cf-0455de2a6a91
Open

Move Eclipse platform dependencies to parent pom dependency management#5409
Copilot wants to merge 1 commit intomainfrom
copilot/fix-9e75fa8d-7996-4484-86cf-0455de2a6a91

Conversation

Copy link
Contributor

Copilot AI commented Sep 30, 2025

Overview

This PR centralizes Eclipse platform dependency version management by moving 32 dependencies from individual module pom.xml files to the parent pom's dependencyManagement section. This addresses the issue raised in #3286 to better organize dependencies that were added during the OSGi→Maven transition.

Changes

Parent POM

Added 32 Eclipse platform dependencies to the dependencyManagement section:

  • Eclipse EMF (1): org.eclipse.emf.ecore
  • Eclipse JDT (3): org.eclipse.jdt.core.manipulation, org.eclipse.jdt.launching, org.eclipse.jdt.ui
  • Eclipse PDE (3): org.eclipse.pde.api.tools, org.eclipse.pde.core, org.eclipse.pde.ui
  • Eclipse Platform (25): Various equinox and platform bundles including p2, UI, and core components

Module POMs

Removed explicit version tags from 25 module pom.xml files where these dependencies are used, allowing them to inherit versions from the parent's dependency management.

Benefits

  1. Easier dependency updates - Dependabot and manual updates can now target a single location instead of multiple scattered versions
  2. Version consistency - Guarantees all modules use the same version of each Eclipse platform dependency
  3. Reduced duplication - Eliminates 66 redundant version declarations across the codebase
  4. Better organization - Eclipse dependencies are now logically grouped in the parent POM
  5. Future-proof - Makes it easier to adopt platform BOMs or feature-based dependencies in the future

Testing

All affected modules compile successfully:

  • p2-maven-plugin (20 dependencies managed)
  • tycho-cleancode-plugin (6 dependencies managed)
  • tycho-build (7 dependencies managed)
  • tycho-core, tycho-apitools-plugin, tycho-baseline-plugin, and 19 other modules

Verified dependency resolution confirms all versions are correctly inherited from parent's dependency management.

Notes

  • Only moved dependencies with group ID org.eclipse.* (excluding org.eclipse.tycho and org.eclipse.sisu which are internal to Tycho)
  • All existing formatting and structure preserved in modified files
  • Property-based versions (e.g., ${project.version}) were not modified

Fixes #3286

Original prompt

This section details on the original issue you should resolve

<issue_title>Move eclipse-platform dependencies to the parent pom into a dependency mangement section</issue_title>
<issue_description>Due to the transition from OSGi>Maven a lot of dependencies where added here and there to make it happen.

Now the transition is done, it would be good to "organize" this a bit, eg. make them all managed dependencies @mickaelistria is there a feature in m2e to automate this task?

@akurtakov maybe you want to help here?

This will make updates easier especially with dependabot. Tycho might also be a good approval of how good platform poms are shaped, currently we need to manually pull in a lot of stuff where one would expect to only require some kind of "root dependency" that pull ins everything else.

Also we currently do not publish feature to maven, it would actually be good to do so and let these feature declare dependencies in their pom so that for example Tycho at best only need to require something like "equinox.core.feature" or "p2.core.feature" to pull in all required items ...</issue_description>

<agent_instructions>All maven dependencies that are starting with the group id org.eclipse that are defined in pom.xml of the different maven modules should get their version managed in the dependency management section of the parent pom.xml in the root of the repository.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@akurtakov I am not aware of any automation for this. Usually I wait for dependabot to kick in (should happen with 2022-12 release) and when I notice it to update same artifact version in more than one place move it to managed one. I'll keep an eye (and try to help) with this once platform builds (mainly tests) are a bit more stable. @laeubi > I am not aware of any automation for this.

I created

Fixes #1577

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI changed the title [WIP] Move eclipse-platform dependencies to the parent pom into a dependency mangement section Move Eclipse platform dependencies to parent pom dependency management Sep 30, 2025
Copilot AI requested a review from laeubi September 30, 2025 16:17
@laeubi laeubi force-pushed the copilot/fix-9e75fa8d-7996-4484-86cf-0455de2a6a91 branch from 4ca9e26 to d0ee5d6 Compare October 12, 2025 16:52
@laeubi laeubi marked this pull request as ready for review October 12, 2025 16:52
@github-actions
Copy link

Test Results

1 014 files  1 014 suites   6h 2m 49s ⏱️
1 298 tests 1 276 ✅ 20 💤 2 ❌
3 894 runs  3 829 ✅ 63 💤 2 ❌

For more details on these failures, see this check.

Results for commit d0ee5d6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move eclipse-platform dependencies to the parent pom into a dependency mangement section

2 participants