Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual thread support #4916

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Virtual thread support #4916

merged 3 commits into from
Oct 25, 2023

Conversation

vietj
Copy link
Member

@vietj vietj commented Oct 24, 2023

Support virtual thread in Vert.x adding support for Future#await when deployment virtual thread verticles.

Since we introduce a new DeploymentOptions#threadingModel, DeploymentOptions#worker is deprecated, options.setWorker(true) should be replaced by options.setThreadingModel(ThreadingModel.WORKER)

@vietj vietj added this to the 4.5.0 milestone Oct 24, 2023
@vietj vietj force-pushed the virtual-thread-support-4.x branch 4 times, most recently from a75f204 to 30ad6d4 Compare October 24, 2023 15:38
@vietj vietj self-assigned this Oct 24, 2023
@vietj vietj force-pushed the virtual-thread-support-4.x branch 5 times, most recently from ac99593 to d50dd01 Compare October 24, 2023 16:14
Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job @vietj !

src/main/asciidoc/index.adoc Outdated Show resolved Hide resolved
src/main/java/io/vertx/core/impl/WorkerExecutor.java Outdated Show resolved Hide resolved
src/main/asciidoc/virtualthreads.adoc Show resolved Hide resolved
@vietj
Copy link
Member Author

vietj commented Oct 24, 2023

LGTM, good job @vietj !

we had a good brainstorm session this morning :-)

@vietj vietj force-pushed the virtual-thread-support-4.x branch from ef19058 to d78d4c8 Compare October 24, 2023 16:54
@vietj vietj force-pushed the virtual-thread-support-4.x branch from d78d4c8 to 5faf2d4 Compare October 24, 2023 17:15
Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestions. I like the way virtual threads support is shaping up.

BTW we should document the case of awaiting multiple futures.

src/main/asciidoc/virtualthreads.adoc Outdated Show resolved Hide resolved
src/main/asciidoc/virtualthreads.adoc Outdated Show resolved Hide resolved
src/main/asciidoc/virtualthreads.adoc Outdated Show resolved Hide resolved
src/main/java/io/vertx/core/DeploymentOptions.java Outdated Show resolved Hide resolved
src/main/java/io/vertx/core/DeploymentOptions.java Outdated Show resolved Hide resolved
src/main/java/io/vertx/core/Future.java Show resolved Hide resolved
src/main/java/io/vertx/core/Vertx.java Outdated Show resolved Hide resolved
src/main/java/io/vertx/core/impl/DeploymentManager.java Outdated Show resolved Hide resolved
src/main/java/io/vertx/core/impl/Utils.java Show resolved Hide resolved
src/main/java/io/vertx/core/impl/VertxImpl.java Outdated Show resolved Hide resolved
@vietj
Copy link
Member Author

vietj commented Oct 24, 2023

See my suggestions. I like the way virtual threads support is shaping up.

BTW we should document the case of awaiting multiple futures.

we need a structured concurrency section ;-)

@vietj
Copy link
Member Author

vietj commented Oct 24, 2023

thanks for the review, I'll squash the commits tomorrow to facilitate the port to master

@vietj vietj force-pushed the virtual-thread-support-4.x branch from 81b4b92 to 18a45aa Compare October 25, 2023 07:28
@vietj vietj force-pushed the virtual-thread-support-4.x branch from 18a45aa to f150fb1 Compare October 25, 2023 07:42
@vietj vietj merged commit 689a76f into 4.x Oct 25, 2023
@vietj vietj deleted the virtual-thread-support-4.x branch October 25, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants