-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual thread support #4916
Virtual thread support #4916
Conversation
a75f204
to
30ad6d4
Compare
ac99593
to
d50dd01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job @vietj !
we had a good brainstorm session this morning :-) |
ef19058
to
d78d4c8
Compare
d78d4c8
to
5faf2d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestions. I like the way virtual threads support is shaping up.
BTW we should document the case of awaiting multiple futures.
we need a structured concurrency section ;-) |
thanks for the review, I'll squash the commits tomorrow to facilitate the port to master |
81b4b92
to
18a45aa
Compare
18a45aa
to
f150fb1
Compare
Support virtual thread in Vert.x adding support for
Future#await
when deployment virtual thread verticles.Since we introduce a new
DeploymentOptions#threadingModel
,DeploymentOptions#worker
is deprecated,options.setWorker(true)
should be replaced byoptions.setThreadingModel(ThreadingModel.WORKER)