Skip to content

Conversation

magicprinc
Copy link
Contributor

Future has await() method without timeout

It is easy to implement and nice to have await(timeout,TimeUnit) method

@vietj
Copy link
Member

vietj commented Nov 23, 2023

that is not needed since it possible to use timeout on a future, i.e await(future.timeout(timeout)), instead we should document this usage in the documentation.

@vietj vietj closed this Nov 23, 2023
@magicprinc
Copy link
Contributor Author

@vietj Then #4958
NullPointerException is real (see test)
And quick path for already completed futures is also a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants