Issue 5676: Introduced the option to fall back to TCP when DNS resolv… #5692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we are missing a test for this |
…ing via UDP fails with a timeout
vietj
force-pushed
the
feature/4.x-issue-5676-tcp-dns
branch
from
4455154 to
733e100
Compare
|
I thought about testing this, but all Vertx does here is pass the parameter to the Netty resolver. So I just tested this new functionality. Writing a test which checks whether the fallback actually works is out of scope here from my point of view, and I think it would require a lot of mocking and/or dependencies to Netty internals, which would make the test hard to maintain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5676