Skip to content

Conversation

@ahus1
Copy link
Contributor

@ahus1 ahus1 commented Dec 27, 2025

Closes #5865

Motivation:

Setting expirationTimestamp is required before the connection is recycled to ensure that the background timer executed correctly.

In a previous attempt I tried to set the initial value to Long.MAX_VALUE, but then Http2Test.testClientKeepAliveTimeoutNoStreams started failing. So I'm no setting it a value using recycle().

@ahus1 ahus1 force-pushed the is-5865-connection-impl-keepalive branch from e0df732 to 1eb0c76 Compare December 27, 2025 16:39
@ahus1 ahus1 marked this pull request as ready for review December 27, 2025 17:16
@vietj
Copy link
Member

vietj commented Jan 7, 2026

@ahus1 is that possible to have a test for this ?

@ahus1
Copy link
Contributor Author

ahus1 commented Jan 8, 2026

@vietj - this is fixing an unstable test that I referenced in the issue #5865. As it is about a timing issue, I wouldn't know how to implement a test case for this.

Can you please elaborate on what kind if test case you are looking for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unstable test Http2Test.testKeepAliveTimeout

2 participants