Skip to content

feat: support protoc options #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

comynli
Copy link

@comynli comynli commented May 9, 2025

Protobuf compiler typically pass arguments using -xxx_out=options:$path or -xxx_opt=options. This PR makes the vertx-grpc-protoc-plugin2 follow this convention

@vietj
Copy link
Member

vietj commented May 9, 2025

we should be consistent and name like for the Maven plugin "grpc-io" and not "io", etc...

can you sign the Eclipse Contributor Agreement ?

@vietj vietj added this to the 5.0.0 milestone May 9, 2025
@comynli
Copy link
Author

comynli commented May 11, 2025

we should be consistent and name like for the Maven plugin "grpc-io" and not "io", etc...
Ok, I'll fix it quickly.

@vietj
Copy link
Member

vietj commented May 11, 2025

@comynli you need also to sign the eclipse contributor agreement so we can accept your contribution

@comynli
Copy link
Author

comynli commented May 12, 2025

@comynli you need also to sign the eclipse contributor agreement so we can accept your contribution

Already done. I am very sorry, I am not very familiar with English, and I spent some time understanding it.

@vietj
Copy link
Member

vietj commented May 12, 2025

can you instead reuse the same command line parser instead of parsing with a different syntax

@vietj vietj modified the milestones: 5.0.0, 5.1.0, 5.0.1 May 14, 2025
@zZHorizonZz
Copy link
Member

Could we maybe use this type of options in IT test module instead of args to ensure everything works as expected? What do you think @vietj

@vietj
Copy link
Member

vietj commented May 25, 2025

@zZHorizonZz I am not sure what you mean, can you elaborate ?

@zZHorizonZz
Copy link
Member

zZHorizonZz commented May 26, 2025

So I think we need to be able to test this somehow, because hoping that this won't break with potential updates etc. doesn't seem like a good idea. So I think we should at least be able to test it, and because you should be able to pass the plugin parameters through <pluginParameter></pluginParameter>, that should basically trigger this type of argument parsing? Other variant is to have possibly gradle project which is using this, as folder and triggere it during build?

@comynli
Copy link
Author

comynli commented May 27, 2025

can you instead reuse the same command line parser instead of parsing with a different syntax

Sorry, this has been quite a busy day. Do you mean to use Picocli to parse the parameters passed to the plugin by protoc? Or should it maintain the same behavior as args?

@vietj
Copy link
Member

vietj commented May 27, 2025

we would like to support a single way to transform a stream of tokens into the plugin configuration using the picocli engine

@vietj vietj modified the milestones: 5.0.1, 5.0.2 Jun 24, 2025
@vietj vietj modified the milestones: 5.0.2, 5.0.3 Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants