-
Notifications
You must be signed in to change notification settings - Fork 34
feat: support protoc options #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
we should be consistent and name like for the Maven plugin "grpc-io" and not "io", etc... can you sign the Eclipse Contributor Agreement ? |
|
@comynli you need also to sign the eclipse contributor agreement so we can accept your contribution |
Already done. I am very sorry, I am not very familiar with English, and I spent some time understanding it. |
can you instead reuse the same command line parser instead of parsing with a different syntax |
Could we maybe use this type of options in IT test module instead of args to ensure everything works as expected? What do you think @vietj |
@zZHorizonZz I am not sure what you mean, can you elaborate ? |
So I think we need to be able to test this somehow, because hoping that this won't break with potential updates etc. doesn't seem like a good idea. So I think we should at least be able to test it, and because you should be able to pass the plugin parameters through |
Sorry, this has been quite a busy day. Do you mean to use |
we would like to support a single way to transform a stream of tokens into the plugin configuration using the picocli engine |
Protobuf compiler typically pass arguments using -xxx_out=options:$path or -xxx_opt=options. This PR makes the vertx-grpc-protoc-plugin2 follow this convention