Support repeated fields in HTTP variable bindings#244
Merged
vietj merged 3 commits intoeclipse-vertx:mainfrom Mar 17, 2026
Merged
Support repeated fields in HTTP variable bindings#244vietj merged 3 commits intoeclipse-vertx:mainfrom
vietj merged 3 commits intoeclipse-vertx:mainfrom
Conversation
vietj
reviewed
Mar 3, 2026
vertx-grpc-common/src/main/java/io/vertx/grpc/common/GrpcMessageDecoder.java
Show resolved
Hide resolved
vietj
approved these changes
Mar 16, 2026
Member
|
LGTM @zZHorizonZz |
Motivation: - Enable proper handling of repeated fields in gRPC messages during HTTP transcoding. Changes: - Updated `MessageWeaver` to identify and weave repeated fields using protobuf descriptors. - Expanded unit tests to cover repeated fields at various nesting levels. - Added tests for repeated query parameters in `ServerTranscodingTest`. Signed-off-by: Daniel Fiala <[email protected]>
…ecoder Changes: - Replaced `Async` assertions in gRPC transcoding tests with `await` - Fix BridgeMessageDecoder to return Descriptor if messageLite is Message
zZHorizonZz
force-pushed
the
fix-transcoding-query-repeated
branch
from
9fcab8a to
513f272
Compare
Member
|
@zZHorizonZz can you backport this contribution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Changes:
MessageWeaverto identify and weave repeated fields using protobuf descriptors.ServerTranscodingTest.