Wait for @AfterEach method's VertxTestContext in case a @Test method failed #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsegismont
reviewed
Oct 17, 2025
There was a problem hiding this comment.
Thanks for this PR @alsin
Please see comments inline. When updating the PR, please sign-off your commits (using the email that is registered at the Eclipse Fdn for your contributor agreement).
Comment on lines
+183
to
+190
| final boolean isNotInAfterEachMethod = Optional.ofNullable(invocationContext) | ||
| .map(ReflectiveInvocationContext::getExecutable) | ||
| .map(executable -> executable.getAnnotation(AfterEach.class)) | ||
| .isEmpty(); | ||
|
|
||
| if (isNotInAfterEachMethod) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This might fix the problem for @AfterEach methods, but not for @AfterAll ones.
The extension creates a new VertxTestContext for each intercepted method. I think the criterion for waiting the completion of the context should be that the execution exception hasn't changed during the invocation
src/test/java/io/vertx/junit5/tests/WaitForContextInAfterEachMethodTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If a
@Testmethod fails then potentialVertxTestContextinjected into a@AfterEachmethod (if any, of course) is not awaited.For instance, a test might want to perform test data cleanup in a series of asynchronous operations in such a @AfterEach method and
VertxTestContextcould be used to gracefully wait for their end of operation. Unfortunately, as of now, if a test fails it does not wait for the test context injected into an after test method.Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines