Skip to content

Conversation

dennisschroer
Copy link

Motivation:

When a timeout occurs while waiting for a new connection, the future fails with a simple "Timeout" message without a stack trace. This makes it very difficult to debug where in the application the error occurs. We have a longer running process with multiple requests to the database, and having a stacktrace would help us.

Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

@dennisschroer dennisschroer force-pushed the fail-with-exception-on-timeout branch from 994f719 to 64f33ae Compare July 31, 2023 13:02
@dennisschroer dennisschroer requested a review from vietj August 1, 2023 08:05
@vietj
Copy link
Member

vietj commented Aug 30, 2023

can you reproduce this case with a test ? it is not clear how it happens.

I would like this behaviour to be tested and the only case it can happen is when the connection pool is too busy to respond (which shall not happen unless it is blocked) or when there is a race with the acquisition (basically cancel succeeds and returns false, it was not able to cancel because the handler got satisfied which makes the connection borrower progress).

also this callback cannot fail, it is always completed with a succeeded future, unless the pool is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants