Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide JSON coordinate options #1071

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Provide JSON coordinate options #1071

wants to merge 24 commits into from

Commits on Aug 24, 2024

  1. Target platform changes?

    @skieffer
    skieffer committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    915fa24 View commit details
    Browse the repository at this point in the history

  2. Update .gitignore

    @skieffer
    skieffer committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    d07e112 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Supply missing map clear

    @skieffer
    skieffer committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    d34db90 View commit details
    Browse the repository at this point in the history

  2. Add maps to support coordinate adjustments 

    * Record the original parent of each edge, before the call to
  `updateContainment()`.

* Split the layout transfer into two passes: Pass 1 does everything
  except edges; Pass 2 does edges. This allows us to compute the
  global coords of each node, before working on the edges.

* In this commit, we add some diagnostic output to the final JSON,
  which is probably not ultimately wanted. (Global coords, and original
  parents.)
    @skieffer
    skieffer committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    9976add View commit details
    Browse the repository at this point in the history

  3. Add comments

    @skieffer
    skieffer committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    3e63089 View commit details
    Browse the repository at this point in the history

  4. Add org.eclipse.elk.json.edgeCoords property 

    For now, we don't do anything with it except note the enum ordinal
in the JSON for each edge.
    @skieffer
    skieffer committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    7208ee3 View commit details
    Browse the repository at this point in the history

  5. Adjust edge coordinates according to mode

    @skieffer
    skieffer committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    4d49d8b View commit details
    Browse the repository at this point in the history

  6. Use extension methods

    @skieffer
    skieffer committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    4f76fa0 View commit details
    Browse the repository at this point in the history

  7. Add unit tests

    @skieffer
    skieffer committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    3683032 View commit details
    Browse the repository at this point in the history

  8. Use do-while loop

    @skieffer
    skieffer committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    0300a97 View commit details
    Browse the repository at this point in the history

  9. Remove diagnostic output

    @skieffer
    skieffer committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f72a435 View commit details
    Browse the repository at this point in the history

  10. Revert incidental changes

    @skieffer
    skieffer committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    6d152c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Use static method instead of deprecated json parser constructor 

    (Applying suggestions from code review)

Co-authored-by: Sören Domrös <[email protected]>
    @skieffer @soerendomroes
    skieffer and soerendomroes authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1cdd859 View commit details
    Browse the repository at this point in the history

  2. Avoid NPE 

    (applying suggestion from code review)

Co-authored-by: Sören Domrös <[email protected]>
    @skieffer @soerendomroes
    skieffer and soerendomroes authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b1a02bc View commit details
    Browse the repository at this point in the history

  3. Remove additional cases of deprecated json parser constructor

    @skieffer
    skieffer committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    331b06a View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Use PlainJavaInitialization in test 

    Co-authored-by: Sören Domrös <[email protected]>
    @skieffer @soerendomroes
    skieffer and soerendomroes authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8c03b80 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Determine edge coord modes more efficiently 

    Now determined for each node only once, on the first traversal.
    @skieffer
    skieffer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9a4d24f View commit details
    Browse the repository at this point in the history

  2. Simplify adjustment method signature 

    Also move definitions down in file.
    @skieffer
    skieffer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5e581f5 View commit details
    Browse the repository at this point in the history

  3. Make edge labels use same coord system as edge

    @skieffer
    skieffer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0f8a544 View commit details
    Browse the repository at this point in the history

  4. Add EOF newline

    @skieffer
    skieffer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    81e082b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Support org.eclipse.elk.json.shapeCoords property

    @skieffer
    skieffer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    52fed6d View commit details
    Browse the repository at this point in the history

  2. Update docs to cover coordinate options

    @skieffer
    skieffer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5d7cf1a View commit details
    Browse the repository at this point in the history

  3. Write container property into edges only in CONTAINER mode 

    Also, mention this in the docs.
    @skieffer
    skieffer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    2312415 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Improve property descriptions

    @skieffer
    skieffer committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    82ea83d View commit details
    Browse the repository at this point in the history