-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [Database] Deprecate db.pool.size.*
settings
#4112
Draft
Coduz
wants to merge
5
commits into
eclipse:develop
Choose a base branch
from
Coduz:feat-deprecateDbPoolSettings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coduz
force-pushed
the
feat-deprecateDbPoolSettings
branch
from
October 2, 2024 12:52
605871b
to
3e00177
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4112 +/- ##
==========================================
Coverage 16.81% 16.81%
Complexity 22 22
==========================================
Files 2019 2019
Lines 52431 52432 +1
Branches 4421 4421
==========================================
+ Hits 8816 8817 +1
Misses 43218 43218
Partials 397 397
|
Coduz
force-pushed
the
feat-deprecateDbPoolSettings
branch
from
October 2, 2024 13:31
3e00177
to
48aa8d6
Compare
Coduz
changed the title
[recycle] [Database] Deprecate
♻️ [Database] Deprecate Oct 2, 2024
db.pool.size.*
settingsdb.pool.size.*
settings
Coduz
force-pushed
the
feat-deprecateDbPoolSettings
branch
from
October 8, 2024 08:10
48aa8d6
to
dc4c9b4
Compare
Coduz
force-pushed
the
feat-deprecateDbPoolSettings
branch
from
October 28, 2024 15:17
dc4c9b4
to
a4105b1
Compare
Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
…ings Signed-off-by: Alberto Codutti <[email protected]>
…ttings in favor of 'db.pool.size' Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
Coduz
force-pushed
the
feat-deprecateDbPoolSettings
branch
from
October 31, 2024 15:12
a4105b1
to
d72259d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
commons.db.pool.size.min
andcommons.db.pool.size.max
settings since they have changed their meaning/usage after #4067Related Issue
This PR improves changes made in #4067
Description of the solution adopted
Deprecated usage of:
commons.db.pool.size.min
- not used since $4067commons.db.pool.size.max
- replaced bycommons.db.pool.size
due to :fix: set hikari configuration pool to fixed size (more performant) #4067commons.db.pool.idle.timeout
- not used since $4067Removed:
commons.db.pool.size.initial
- not used nor referencedcommons.db.pool.borrow.timeout
- not used nor referencedwhich were no longer used.
Introduced a new
commons.db.pool.size
setting to manage the fixed pool size.Screenshots
None
Any side note on the changes made
Introduced
UPGRADE_NOTES.md
file to start maintaining a verbose upgrade notes log for notable changes in version