Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [Database] Deprecate db.pool.size.* settings #4112

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Oct 2, 2024

This PR deprecates commons.db.pool.size.min and commons.db.pool.size.max settings since they have changed their meaning/usage after #4067

Related Issue
This PR improves changes made in #4067

Description of the solution adopted
Deprecated usage of:

Removed:

  • commons.db.pool.size.initial - not used nor referenced
  • commons.db.pool.borrow.timeout - not used nor referenced

which were no longer used.

Introduced a new commons.db.pool.size setting to manage the fixed pool size.

Screenshots
None

Any side note on the changes made
Introduced UPGRADE_NOTES.md file to start maintaining a verbose upgrade notes log for notable changes in version

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Oct 2, 2024
@Coduz Coduz force-pushed the feat-deprecateDbPoolSettings branch from 605871b to 3e00177 Compare October 2, 2024 12:52
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.81%. Comparing base (57f10be) to head (dc4c9b4).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4112   +/-   ##
==========================================
  Coverage      16.81%   16.81%           
  Complexity        22       22           
==========================================
  Files           2019     2019           
  Lines          52431    52432    +1     
  Branches        4421     4421           
==========================================
+ Hits            8816     8817    +1     
  Misses         43218    43218           
  Partials         397      397           
Files with missing lines Coverage Δ
...java/org/eclipse/kapua/commons/jpa/DataSource.java 94.11% <100.00%> (ø)
...kapua/commons/setting/system/SystemSettingKey.java 100.00% <100.00%> (ø)

@Coduz Coduz force-pushed the feat-deprecateDbPoolSettings branch from 3e00177 to 48aa8d6 Compare October 2, 2024 13:31
@Coduz Coduz changed the title [recycle] [Database] Deprecate db.pool.size.* settings ♻️ [Database] Deprecate db.pool.size.* settings Oct 2, 2024
@Coduz Coduz marked this pull request as draft October 7, 2024 12:48
@Coduz Coduz force-pushed the feat-deprecateDbPoolSettings branch from 48aa8d6 to dc4c9b4 Compare October 8, 2024 08:10
@Coduz Coduz force-pushed the feat-deprecateDbPoolSettings branch from dc4c9b4 to a4105b1 Compare October 28, 2024 15:17
@Coduz Coduz force-pushed the feat-deprecateDbPoolSettings branch from a4105b1 to d72259d Compare October 31, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant