Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [REST-API] Add support to query operations by status in GET /{scopeId}/devices/{deviceId}/operations #4121

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

MDeLuise
Copy link
Contributor

@MDeLuise MDeLuise commented Oct 18, 2024

Description

This PR implements the capability to search operations by their status using the GET /{scopeId}/devices/{deviceId}/operations endpoint.

Changes Made

  • New Feature: Added functionality to filter operations based on their status.
  • Refactor: Modified the DeviceManagementOperations query method to support additional predicates.

The current query method was refactored because it was enforcing a "filter by device ID" constraint on all queries, regardless of any other predicates provided. This limitation prevented any other filtering criteria (e.g., status) from being applied, so the method has been updated to allow flexible filtering based on multiple criteria.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 16.80%. Comparing base (d5e338d) to head (a94041c).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...urces/v1/resources/DeviceManagementOperations.java 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4121      +/-   ##
=============================================
- Coverage      16.80%   16.80%   -0.01%     
  Complexity        22       22              
=============================================
  Files           2021     2021              
  Lines          52463    52468       +5     
  Branches        4424     4425       +1     
=============================================
  Hits            8815     8815              
- Misses         43250    43255       +5     
  Partials         398      398              
Files with missing lines Coverage Δ
...urces/v1/resources/DeviceManagementOperations.java 0.00% <0.00%> (ø)

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Oct 28, 2024
…opeId}/devices/{deviceId}/operations`

- Implemented the ability to query operations based on their status via the `GET /{scopeId}/devices/{deviceId}/operations` endpoint.
- Fix `DeviceManagementOperations` query method to support the new functionality
- Updated documentation accordingly.
@Coduz Coduz merged commit 94c240d into eclipse:develop Oct 30, 2024
32 of 33 checks passed
@MDeLuise MDeLuise deleted the improve-deviceOpSearchStatus branch October 30, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
Development

Successfully merging this pull request may close these issues.

2 participants