Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f:ix allow to set a classloader for PackageSpecificTypeAdapter #331

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Jul 19, 2023

Description

In order to allow the PackageSpecificTypeAdapter also work within context of applications, the correct class loader must be specified. This is now possible with this given change. The application code which uses this type adapter must now pass the SimulationKernel.SimulationKernel.getClassLoader() to this type adapter.

Issue(s) related to this PR

  • Resolves issue internal issue 620

Affected parts of the online documentation

Changes in the documentation required?

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab added the bugfix Pull requests that fixes a bug label Jul 19, 2023
@kschrab kschrab requested a review from schwepmo July 19, 2023 16:37
Copy link
Contributor

@schwepmo schwepmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition of documentation and a valid workaround passing the class loader 👍

@schwepmo schwepmo merged commit bcee4f6 into main Jul 20, 2023
1 check passed
@kschrab kschrab deleted the 620-package-type-adapter-for-apps branch July 26, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull requests that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants