Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(perception): Improve generics usag in perception module #416

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

improvement(perception): Improve generics usag in perception module #416

wants to merge 19 commits into from

Conversation

schwepmo
Copy link
Contributor

Description

  • This PR implements a more coherent way to use generics when handling different SpatialObjects
  • Additionally some cleanup was done
  • This should be merged after build: migrate to Java 17 #410

Issue(s) related to this PR

  • not related to an issue

Affected parts of the online documentation

Changes in the documentation required?

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

kschrab and others added 19 commits September 9, 2024 18:21
@kschrab
feat: set Java 17 as source/target language level
c34b17c
@kschrab
refactor: use pattern matching for instanceof #java17
5cb1036
@kschrab
ci: upgrade spotbugs-maven-plugin, don't execute analysis in parallel
ce7d228
@kschrab
ci: upgrade spotbugs-maven-plugin
02038c4
@kschrab
refactor: use Stream.toList() #java17
0230f87
@kschrab
refactor: use switch expressions #java17
225299f
@kschrab
refactor: use record for some inner classes #java17
b8e7feb
@kschrab
fix: fix broken test
97381ce
@kschrab
refactor: use text blocks #java17
f1be237
@kschrab
ci: go back to spotbugs 4.2.3
4dc28b3
@kschrab
ci: update docker image for builds on eclipse CI
636a1d5
@kschrab
ci: go back to spotbugs 4.2.2
05d39ce
@kschrab
ci: use spotbugs 4.2.3
7c524f2
@kschrab
refactor: use pattern matching for instanceof and Stream.toList #java17
4878d86
@kschrab
build: use JDK 17 in github action
398c759
@kschrab
Merge remote-tracking branch 'origin/891-java-17' into 891-java-17
7b9c8ba
@kschrab
clean(sns): remove unnecessary default case
c5f6aa7
@schwepmo
improvement(perception): improved generics handling in perception module
9b2559b 
* furthermore some minor adjustments were made
* code analysis warnings should also be improved

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo
improvement(perception): adjusted some comments
41b2105 
Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo schwepmo added the clean-up Aesthetically improving code label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clean-up Aesthetically improving code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schwepmo @kschrab