Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run windows-mosaic with wsl-ns3 #425

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

hoelger
Copy link
Contributor

@hoelger hoelger commented Oct 16, 2024

Description

Enable to start ns3 from windows-mosaic

Issue(s) related to this PR

  • Resolves internal issue 894

Affected parts of the online documentation

Changes in the documentation required? yes, PR exists

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab
Copy link
Contributor

kschrab commented Oct 16, 2024

Works like a charm ❤️! You could try to do the same with the OmnetppAmbassador :)

@kschrab kschrab added the enhancement New feature or request label Oct 17, 2024
@kschrab kschrab merged commit bb12ae1 into eclipse:main Oct 17, 2024
5 checks passed
FunKuchen pushed a commit to FunKuchen/mosaic that referenced this pull request Nov 4, 2024
* refactor: don't use this whenever possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants