Skip to content

Conversation

@gnugomez
Copy link
Contributor

Resolves #1548

@gnugomez gnugomez marked this pull request as draft January 15, 2026 12:56
@gnugomez
Copy link
Contributor Author

@netomi As the message's wording closely aligns with the Eclipse Foundation's requirements, I’m adding it as a configurable component instead of creating separate variables for the agreement name and contact email. Does that approach seem suitable to you?

@netomi
Copy link
Contributor

netomi commented Jan 16, 2026

I think the approach is fine, however I have seen some other code also uses "Eclipse Foundation OpenVSX Publisher Agreement", we should have in the page settings a field:

export interface PageSettings {
    pageTitle: string;
    publisherAgreementName: string;

and use that consistently in the codebase imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make publisher agreement name and contact part of page settings

2 participants