Refactor optional concentration_scaling in ecckd #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
reuterbal
reviewed
Nov 4, 2024
| @@ -456,7 +456,7 @@ end subroutine read_spectral_solar_cycle | |||
| ! at nlev layers | |||
| subroutine calc_optical_depth_ckd_model(this, ncol, nlev, istartcol, iendcol, nmaxgas, & | |||
| & pressure_hl, temperature_fl, mole_fraction_fl, & | |||
| & optical_depth_fl, rayleigh_od_fl, concentration_scaling) | |||
| & optical_depth_fl, rayleigh_od_fl, opt_concentration_scaling) | |||
There was a problem hiding this comment.
I would prefer not to change the interface, i.e., keep the name concentration_scaling here - the opt_ prefix is not used elsewhere for optional arguments either.
There was a problem hiding this comment.
Thanks. Let me know if your local tests were successful, then I can perform this change. Any preferences for the naming of the local variable (currently concentration_scaling)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IF (PRESENT(concentration_scaling))checkscalc_optical_depth_ckd_model_vec