Skip to content

Conversation

@grassesi
Copy link
Contributor

@grassesi grassesi commented Jan 20, 2026

Description

Issue Number

closes #1539

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@clessig
Copy link
Collaborator

clessig commented Jan 21, 2026

@Jubeku : you had a case where you wanted to use base-config with train_continue. Why was a new base-config necessary and one could not solve it with overrides?

@Jubeku
Copy link
Contributor

Jubeku commented Jan 21, 2026

@Jubeku : you had a case where you wanted to use base-config with train_continue. Why was a new base-config necessary and one could not solve it with overrides?

Yes, see #1663

@clessig
Copy link
Collaborator

clessig commented Jan 21, 2026 via email

@Jubeku
Copy link
Contributor

Jubeku commented Jan 21, 2026

#1663 (comment)

@sophie-xhonneux
Copy link
Contributor

It would be good for fine-tuning experiments to be able to override the base-config, so that model_inputs, etc can be removed without knowledge of what they were during pre-training

@grassesi
Copy link
Contributor Author

All the usecases mentioned here, can be achieved using the --config flag. Indeed this was the intention of this flag. Care has been taken that every parameter is overwritable. Using the --config flag it is much clearer what actually has been changed specifically for finetuning, it also allows for more modularity: A specific fintuning override could be used for different base configs. Abusing the --base-config flag for this usecase will only lead to more copy-pasting around base configs and pontential errors in doing so. If there anything you want to do that --config is preventing you from doing, please let me know and I am happy to find a solution.

@grassesi grassesi force-pushed the sgrasse/develop/1539_set_base_config_fix branch from 18de0df to af351ab Compare January 26, 2026 14:02
@grassesi grassesi marked this pull request as ready for review January 26, 2026 14:05
@simone99n
Copy link
Contributor

Was this PR replaced by PR#1738?

@grassesi
Copy link
Contributor Author

grassesi commented Feb 1, 2026

Was this PR replaced by PR#1738?

No this is complementary to #1738 but less urgent

@grassesi grassesi requested a review from Jubeku February 1, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Flag to set the base config from the CLI

5 participants