-
Notifications
You must be signed in to change notification settings - Fork 51
Make base-config flag exclusive to fresh training, allow empty #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Make base-config flag exclusive to fresh training, allow empty #1661
Conversation
|
@Jubeku : you had a case where you wanted to use base-config with train_continue. Why was a new base-config necessary and one could not solve it with overrides? |
|
But why do you need a new base config and cannot just overwrite the relevant parameters. Maybe you can be more specific in the other issue you created
…________________________________
From: Julian Kuehnert ***@***.***>
Sent: Wednesday, January 21, 2026 9:58:20 AM
To: ecmwf/WeatherGenerator ***@***.***>
Cc: Christian Lessig ***@***.***>; Comment ***@***.***>
Subject: Re: [ecmwf/WeatherGenerator] Make base-config flag exclusive to fresh training, allow empty (PR #1661)
[https://avatars.githubusercontent.com/u/23659747?s=20&v=4]Jubeku left a comment (ecmwf/WeatherGenerator#1661)<#1661 (comment)>
@Jubeku<https://github.com/Jubeku> : you had a case where you wanted to use base-config with train_continue. Why was a new base-config necessary and one could not solve it with overrides?
Yes, see #1663<#1663>
—
Reply to this email directly, view it on GitHub<#1661 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHCHOHVLXX6INZGAFVKIG4L4H45SZAVCNFSM6AAAAACSJF62RWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONZWHEZTANBRGE>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
It would be good for fine-tuning experiments to be able to override the base-config, so that model_inputs, etc can be removed without knowledge of what they were during pre-training |
|
All the usecases mentioned here, can be achieved using the |
18de0df to
af351ab
Compare
|
Was this PR replaced by PR#1738? |
Description
Issue Number
closes #1539
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60