Sophiex/dev/efficient bilin #1684
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ae_aggregation_engine. More checnking needed.
…iex/dev/include-reg-tokens-in-query-agg-engine
…herGenerator into sophiex/dev/include-reg-tokens-in-query-agg-engine
TODO bias flag reset params clean up
…/dev/include-reg-tokens-in-query-agg-engine
…d_shard() to better support all use cases.
…github.com:ecmwf/WeatherGenerator into sophiex/dev/include-reg-tokens-in-query-agg-engine
I think it still hangs in multi-GPU mode even with just DDP :/
…o sophiex/dev/efficient-bilin
…ty or when is_forcing: True is set
clessig
reviewed
Jan 23, 2026
| return torch.cat(outputs, dim=1) | ||
|
|
||
|
|
||
| class EfficientBilinear(torch.nn.Module): |
Collaborator
There was a problem hiding this comment.
Is there a reason to retain the old implementation?
Contributor
Author
There was a problem hiding this comment.
Not really!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the bilinear layer more memory efficient.
Issue Number
Closes #1683
Draft stage, needs option for bias, and reset parameters
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60