[1438] Adding padding to end_date to avoid duplicate samples #1749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TimeWindowHandler doesn't produce enough available forecast initilisation times to choose for samples when run inference on a model trained with$n_{fstep}$ forecast steps and $n_{samples}*dt\geq t_{end} - t_{start}$ .$n_{fstep}=$ $n_{samples}=$ $dt=$ $t_{start}=$ $t_{end}=$
Where
--forecast_steps,--samples,--step_hours,--start,--end(See #1438 and #1085) for more info
This PR provides this padding by working out how many available individual initialisation times there are and adjusting the end of the time window to accomodate that and taking into account the extra time needed to accomodate the number of forecast steps to rollout to
Issue Number
Closes #1438
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60