-
Notifications
You must be signed in to change notification settings - Fork 78
feat: focus area #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: focus area #799
Conversation
for more information, see https://pre-commit.ci
…i-core into feature/reconstruction-plots
for more information, see https://pre-commit.ci
…i-core into feature/reconstruction-plots
for more information, see https://pre-commit.ci
…i-core into feature/reconstruction-plots
for more information, see https://pre-commit.ci
…i-core into feature/reconstruction-plots
…i-core into feature/reconstruction-plots
|
Hi Alberto, I have reviewed the changes. The implementation looks very clean now! I left some minor comments. I also have a more general question: how should the
|
c58a75f to
d40b16c
Compare
@JPXKQX in the current code: So you can specify different focus areas for each dataset, do you still prefer the dict approach? |
|
Update the configs structure, now you can define focus areas for each dataset in the multi dataset setting, and all will be dispayed for each cllback. This also reduces the number of callbacks needed. Here an example: Whic produces the following: |
for more information, see https://pre-commit.ci
…o feature/focus-area
| @@ -0,0 +1,182 @@ | |||
| {"type":"FeatureCollection","features":[ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change is intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new file alltogether, just downloaded and uploaded it



Description
Introduce a focus_area attribute to plot callbacks to focus the plot on a specific area.
Spawns from: #782
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.
📚 Documentation preview 📚: https://anemoi-training--799.org.readthedocs.build/en/799/
📚 Documentation preview 📚: https://anemoi-graphs--799.org.readthedocs.build/en/799/
📚 Documentation preview 📚: https://anemoi-models--799.org.readthedocs.build/en/799/