feat(migrations): remove migration rollback #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
models
documentation
anaprietonem
added
ATS Approved
anaprietonem
approved these changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
LGTM, Thanks @bdvllrs !
I have triggered the integration tests https://github.com/ecmwf/anemoi-core/actions/runs/21623094478 - after those pass it should be good to get this one in
github-project-automation
bot
moved this from To be triaged
to For merging
in Anemoi-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration rollbacks are not used. Worse, the rollback function are defined in migration script but without being implemented.
This means that the migrator will think that all of the migration script can safely be rollbacked when actually they cannot.
I should have probably made the rollback function opt-in in the migration scrip generation CLI rather than opt-out.
Anyway, because the functionality is not used, this PR removes it: less code to maintain and less confusion with what rollbacks are and avoid weird bugs with Python 3.13 and cloudpickle.
This also removes an additional dependency for migrations.
What problem does this change solve?
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.
📚 Documentation preview 📚: https://anemoi-training--830.org.readthedocs.build/en/830/
📚 Documentation preview 📚: https://anemoi-graphs--830.org.readthedocs.build/en/830/
📚 Documentation preview 📚: https://anemoi-models--830.org.readthedocs.build/en/830/