fix: Enable LAM with icon_mesh.py #832
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icon_mesh.py: points in incomplete triangles of coarser/parent grid are provided the closest three grid points instead of removing these points.
for more information, see https://pre-commit.ci
included optional multi_mesh in class ICONMultiMesh
for more information, see https://pre-commit.ci
Code style fix
for more information, see https://pre-commit.ci
HCookie
requested review from
JPXKQX and
MeraX
and removed request for
JPXKQX
Contributor
|
@MeraX would you have some time to look at this? Would be great to check those changes are also fine with the developments you're doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icon_mesh.py: points in incomplete triangles of coarser/parent grid are provided the closest three grid points instead of removing these points.
Description
LAM grid points within a coarser grid were removed, if they were not within a triangle of 3 grid points of the coarser(/parent) grid. This results in an incomplete grid (in particular when applying higher refinement levels)
Assigning these grid points the three closest grid points of the coarser (/parent) grid resolves this issue for these particular cases. For global grids this assignment does not happen and hence, these cases are not affected.
What problem does this change solve?
This is a bugfix, in terms of LAM grids based on ICON grids. However, as ICON-LAM gridded forecasts were not possible with ANEMOI before, this is somehow also a new feature.
What issue or task does this change relate to?
We did not generate an issue number before.
Additional notes
A unit test has not yet been developed as embedded grid developments (ANEMOI forecasts based on local ICON grids) is currently still under development.
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.