refactor(training)!: move grid_indices inside Dataset
#848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
JPXKQX
changed the title
grid_indices inside Dataset
JPXKQX
changed the title
grid_indices inside Datasetgrid_indices inside Dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the dependency of
grid_indicesin the graphs.This will allow graphs to be created later (deeper) in the workflow.
The recommended way to mask the LAM configurations is to use the 'lam_mask_radius_km: 999.9' option in the dataset, rather than using the post-processor in the graph and referencing it later in the data loader configuration.
TODOs :
_setup_batch_sharding()andallgather_batch()to not usegrid_indices.The PR is marked as breaking because the LAM config files will change.
grid_indicesis no longer required in the dataloader configuration.As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.