-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] allow multiple edge builders #70
Open
JPXKQX
wants to merge
9
commits into
develop
Choose a base branch
from
feature/list-of-edge-builders
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCookie
reviewed
Oct 29, 2024
HCookie
reviewed
Nov 12, 2024
HCookie
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code perspective, this looks good to me, however, I am not familiar with the overall design of graphs
, so I would suggest getting another review focusing on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the current functionality to support multiple edge builders between 2 sets of nodes.
edge_builder
field is renamed toedge_builders
, which now requires a list.source/target_mask_attr_name
fields are now specified inside each edge builder.The current implementation lacked support for custom limited-area graphs, which required 2
cutoff_factor
's to connect nodes both within the limited area and along its boundary. They could be instantiated twice in the list of edges. However, edge attribute normalization occurs after each block. Then, we would have to define edge attributes outside of the edge definitions, leading to a loss of flexibility.One new functionality that had to be implemented is
concat_edges()
to concatenate the two sets of edges, dropping the repeated edges.The current config file for a LAM experiment would look like this (including only nodes & encoder edges):
NOTE: This change will break compatibility with graph configurations of previous versions.