-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] support post-processors #71
Open
JPXKQX
wants to merge
18
commits into
develop
Choose a base branch
from
feature/remove-unconnected-nodes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+261
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCookie
reviewed
Oct 28, 2024
…nemoi-graphs into feature/remove-unconnected-nodes
HCookie
reviewed
Oct 29, 2024
HCookie
previously approved these changes
Nov 8, 2024
HCookie
previously approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to create their own post-processors for the graph. In particular, we provide an implementation of
RemoveUnconnectedNodes
which may be useful for LAM, where we want to remove the nodes far from the area of interest.The post-processors are included in the recipe as follows:
Here, we have 2 optional arguments:
ignore
: It allows the user to ignore some nodes based on an existing attribute. For example, do not drop nodes from inside the limited area, even if they are not connected.save_mask_indices_to_attr
: It allows the user to store the indices to mask the nodes from the previous graph to the processed graph as an attribute. This may be needed for training/inference using only the points of interest.