Add scikit-learn dependency to pyproject.toml #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyas
requested review from
theissenhelen,
JesperDramsch,
gmertes,
b8raoult,
floriankrb,
anaprietonem,
HCookie,
JPXKQX and
mchantry
as code owners
|
|
mchantry
approved these changes
Nov 14, 2024
|
No problem! Thank you for opening all of this code up to the community! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anemoi-graphs requires
scikit-learn, e.g. inanemoi.graphs.utils:anemoi-graphs/src/anemoi/graphs/utils.py
Line 14 in 6cfcade
but this package is not included in the pyproject.toml, so I got an ImportError right after installing anemoi-graphs. This very simple PR adds this dependency.