-
Notifications
You must be signed in to change notification settings - Fork 28
feat: multi step prediction #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Multi-out has an issue with accumulated variables that shows up when writing to grib. It seems to go back to a problem with metadata in the checkpoint, so it probably has to be fixed in core. For the moment I have simply suppressed 'tp' output, so that we can continue our scientific evaluation without waiting for this fix in the code. This hardcoded removal of 'tp' in the output makes some tests fail, which is good, so that we wont forget to remove this once the code is closer to merging. |
|
@dietervdb-meteo Can you provide more context on the grib error, we have had some accumulation / step-range issues in the past? |
From what I can see it originates in the Unless this all is a red herring and there is something else going on with the accumulations (after I brought the branch up to date with main). I saw the problem appearing after I fixed the 'step' attribute of the state (and brought the branch up to date). |
|
@dietervdb-meteo We have some work in #392 which may be relevant to this particular issue |
|
It's not a bug. If the model is writing 3 hourly time steps because of the multi-step output, but the accumulations are 6 hourly, then the accumulation at step 3 will have a base time at step -3. That PR allows you to skip the variable, so accumulations will only start being written at step 6, but the question is if it even makes sense to output a 6 hourly accumulations at a 3 hourly step. Maybe the accumulations should also be 3 hourly? |
This PR introduces inference support for ecmwf/anemoi-core#636 , which creates the possibility for the
Forecasterto have multiple output time steps.In inference the
forecast_stepperstill loops over autoregressive ('rollout') steps, but in each such step the model now makesmultistep_outputsubsteps:multistep_output=1example:multistep_output=2example:The current version of the code is a first technically working version, no sanity checks performed yet.
This work is EXPERIMENTAL, considerable work is still required to see if and when this will get merged. In any case that will be after merging of ecmwf/anemoi-core#636
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.