-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sanity checks for training data consistency #120
Open
JesperDramsch
wants to merge
12
commits into
develop
Choose a base branch
from
pre-training-check
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCookie
reviewed
Nov 5, 2024
JesperDramsch
changed the title
Check Variable Sorting during Training
Update sanity checks for training data consistency
Nov 5, 2024
HCookie
previously approved these changes
Nov 11, 2024
HCookie
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a callback that tries to ensure that the variable in the training are in order.
The following scenarios are checked:
Model Scenarios
There are two scenarios for the model:
New Model
A fresh model will get the name_to_index from the training dataset and compare to validation and test on epoch start.
From Checkpoint
A model that is restored from a checkpoint will retrieve the name_to_index in existing data_indices and compare them to instantiated data_indices.
Error Scenarios
There are valid, warning, and error scenarios:
Valid Scenario
The name_to_index is identical
Warnings
When variables are renamed but in the same locations, a warning is issued but training will not be blocked.
Errors
Values are renamed in different locations, which will result in an error.
Values are permuted, will result in an error
Removes the Resolution Check
Currently there is a resolution check, which I was told gets in the way of training with merged datasets et al.
Upon consideration of factoring this into another Callback, I decided to get rid of the check instead, as it would be flaky at best and breaking at the worst.
@HCookie pointed out this was also flagged now in #68