Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null tracker metadata and disable mlflow by default #18

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

gmertes
Copy link
Member

@gmertes gmertes commented Aug 12, 2024

  • This PR fixes the tracker metadata to be empty when there is no tracker, instead of "null".
  • Since the tracking URI is now missing by default, I also changed mlflow to be disabled by default, so that the default training config does not crash.

When tracking is disabled, the metadata contains the following for the tracker:

"tracker": {
    "null": null
}

Instead, it should be an empty object to indicate there was no tracker:

"tracker": {}

@FussyDuck
Copy link

FussyDuck commented Aug 12, 2024

CLA assistant check
All committers have signed the CLA.

@gmertes gmertes added this to the First Release milestone Aug 13, 2024
JesperDramsch
JesperDramsch previously approved these changes Aug 14, 2024
Copy link
Member

@JesperDramsch JesperDramsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

I think we should probably have a check that W&B and MLFlow aren't both enabled, as this would break the tracker info though.

@gmertes
Copy link
Member Author

gmertes commented Aug 14, 2024

I agree. Since I don't think both trackers should be enabled at the same time, that check could be part of the config validation proposed in #1

@gmertes gmertes merged commit cbd3d07 into develop Aug 14, 2024
107 checks passed
@gmertes gmertes deleted the fix/null-tracker branch August 14, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants