-
Notifications
You must be signed in to change notification settings - Fork 17
feat(utils)!: store vcs info in metadata #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Tested like this:
|
| # Regular package - just store version string | ||
| versions[name] = version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than alternate between dict and str, I think just a dict of {'version':version} would be better.
| except (FileNotFoundError, json.JSONDecodeError): | ||
| pass | ||
|
|
||
| except (PackageNotFoundError, Exception) as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a very broad exception catch
Description
This closes #130 by adding more metadata to checkpoints.
What problem does this change solve?
Add more info to checkpoint metadata about modules used in training. The URL, subdirectory and more.
What issue or task does this change relate to?
#130
Additional notes
If someone is parsing the metadata already, this could be a breaking change, but I don't think it is.
Old metadata:
"anemoi.models": "0.12.0",New metadata:
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.