Add array::View interoperability with mdspan #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, following API is added to
array::View
:array::View view{mdspan}
constructorauto mdspan = view.as_mdspan()
function to create an mdspan.Due to general assumptions of
array::View
, theas_mdspan()
function creates amdspan
withlayout_stride
and fully dynamic extents:mdspan<T, dextents<size_t,rank>, layout_stride, default_accessor<T>>
The
array::IndexView
follows a similar API, but theas_mdspan()
function creates amdspan
withindex_accessor
, to convert contain values (indices) to base 1 when Fortran is used.mdspan<T, dextents<size_t,rank>, layout_stride, index_accessor<T,ATLAS_HAVE_FORTRAN>>
💣💥☠️ Static Analyzer Report ☠️💥💣
https://sites.ecmwf.int/docs/atlas/static-analyzer/PR-304