Update MeshBuilder API #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes to allow to use arbitrary indexing base (e.g. 0-based or 1-based) to define nodes, elements and connectivities. - API that uses mdspan - Fixes to allow strided node-coordinates - Allow Fortran array slices for (strided) coordinates in TriangularMeshBuilder
|
Thanks for the ping on this @wdeconinck ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the MeshBuilder and TriangularMeshBuilder API
Changes to allow to use arbitrary indexing base for global_index (e.g. 0-based or 1-based) to define nodes, elements and connectivities.
API that uses mdspan
Fixes to allow strided node-coordinates
Allow Fortran array slices for (strided) coordinates in TriangularMeshBuilder
@fmahebert this may be affecting you. Previous APIs are still working but are deprecated, with a compiler warning.
Just adding a
global_index_baseargument should remove the warning.💣💥☠️ Static Analyzer Report ☠️💥💣
https://sites.ecmwf.int/docs/atlas/static-analyzer/PR-305