-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for v0.9.9.0 release / manage version with setuptools_scm #220
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 92.29% 92.20% -0.10%
==========================================
Files 25 25
Lines 1714 1718 +4
Branches 201 201
==========================================
+ Hits 1582 1584 +2
- Misses 110 112 +2
Partials 22 22
Continue to review full report at Codecov.
|
@iainrussell I tested the release procedure on another package and it is quite straightforward even if not as automatic as before:
The release is as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexamici , this is a very interesting development! I would also like the opinion of @b8raoult - we are making efforts to harmonise our Python packages, and cfgrib would become the odd-one-out if we did this. I'm not personally convinced that these setup tools help much, because if you want to write a changelog that lists the changes per version, you still need some knowledge/control of it. I'm happy to hear arguments for it, or perhaps better, defer it to a later release. I would not want to delay release 0.9.9.0 just because of this.
@iainrussell I just double checked the changes, and in fact I was very careful to include in this PR just the changes in the management of the Note that without this PR you can only release with zest.releaser from a branch, not from a protected I'll open an issue to manage the release, but I'm ready to do it very soon. Even today. |
OK @alexamici , let's do the release (today sounds good!) and consider the version management independently. I'm not sure what you mean about the zest.releaser - I use it to release Metview's Python bindings from a tag on master. |
Following the other major Open Source projects I intend to move cfgrib
to manage its version with
setuptools_scm`.https://github.com/pypa/setuptools_scm
Most of the implementation is taken from xarray.
This makes producing a release form a protected
master
branch much easier.I'm still revising the release procedure with zest.releaser, but it should be simplified as well.