-
Notifications
You must be signed in to change notification settings - Fork 25
Fix/xr engine dims #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pawel-wolff
wants to merge
27
commits into
develop
Choose a base branch
from
fix/xr-engine-dims
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/xr engine dims #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re_dims; some tests corrected
… an attribute and kept as a dimension if included both in `dims_as_attrs` and `ensure_dims` from now on, extra_dims is to declare extra dims while ensure_dims is to declare which size-one dimensions to keep regardless squeezing or dims_as_attrs
…re_dims; some tests corrected
… an attribute and kept as a dimension if included both in `dims_as_attrs` and `ensure_dims` from now on, extra_dims is to declare extra dims while ensure_dims is to declare which size-one dimensions to keep regardless squeezing or dims_as_attrs
…pe>" fix in xr-engine builder in the case allow_holes=True
…e (handle the dim=<level_per_type> as well), then rename_attrs is applied, if present
fix in dims_as_attrs with allow_holes=True
xr-engine attributes tests added
…param" moved to variable_attrs; A related test fixed.
Related notebooks titles improved.
Notebook on xr-engine-dims_as_attrs added. Notebook on xr-engine-squeeze corrected.
Notebook on xr_engine_extra_dims added. Notebook on xr_engine_dims_as_attrs corrected.
Notebook on xr_engine_remapping added
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #867 +/- ##
===========================================
+ Coverage 85.78% 85.81% +0.03%
===========================================
Files 184 184
Lines 14369 14468 +99
Branches 713 727 +14
===========================================
+ Hits 12326 12416 +90
- Misses 1838 1841 +3
- Partials 205 211 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
extra_dims,ensure_dims,dims_as_attrs- by clearly distinguishing between dimension names and metadata keys, in line with the logic introduced by thedim_rolesconcept."<level_per_type>"for the template dimension implemented in theLevelPerTypeDimclass. Under this name, the dimension can be referenced in the options such asensure_dimsanddims_as_attrs."mars"profile by removing several duplicates betweenattrsandvariable_attrs, and moves"param"fromattrstovariable_attrs.ensure_dimsanddims_as_attrsoptions no longer exclusive: one can prevent a size-1 dimension from being squeezed by referencing it inensure_dims, while at the same time promoting a coordinate of that dimension as a variable attribute.All the above improvements and (slight) changes to Xarray engine behaviour are:
to_xarray()method docstring.Contributor Declaration
By opening this pull request, I affirm the following: