Skip to content

Conversation

@Oisin-M
Copy link
Contributor

@Oisin-M Oisin-M commented Jan 27, 2026

Description

Work towards #94.

TODOs:

  • docstrings (with formulae)
  • tests (failing tests are unrelated to this PR)
  • credit scores somewhere
  • would be nice to have: document nan handling

Some open questions:

  • should all functions accept agg_dims etc.?
  • function signature decisions - is over a good name?
  • is this the correct place to put all the verification functions?

Notes for future:

  • xarray metadata - should we rename the variable etc.? (future PR)

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.40%. Comparing base (36e7b50) to head (366a4b9).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #95      +/-   ##
===========================================
+ Coverage    96.97%   99.40%   +2.42%     
===========================================
  Files           21       22       +1     
  Lines         1556     1855     +299     
  Branches        33       35       +2     
===========================================
+ Hits          1509     1844     +335     
+ Misses          42        5      -37     
- Partials         5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Oisin-M Oisin-M changed the title wip: add verification functions from vtb to ek add deterministic verification functions from vtb to earthkit-meteo Jan 30, 2026
@Oisin-M Oisin-M marked this pull request as ready for review January 30, 2026 11:14
Copy link
Collaborator

@oiffrig oiffrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I'm happy to see this grow :)

@Oisin-M Oisin-M requested a review from oiffrig February 2, 2026 08:49
@Oisin-M Oisin-M requested a review from oiffrig February 3, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants