chore: Integration tests #18
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmi
reviewed
Sep 10, 2025
tmi
reviewed
Sep 10, 2025
tests/executor.py
Outdated
| url = "tcp://localhost:12345" | ||
| import socket | ||
|
|
||
| def is_port_in_use(port: int) -> bool: |
Contributor
There was a problem hiding this comment.
i'm bit puzzled by the logic here
from the contextmanager below, it seems to me that you are intending to have each job its own gateway, but not run them in parallel -- ie, test starts a gateway, runs a job, tears down a gateway
but then I'm puzzled why do you have this is_port_in_use function here -- if its in use, how would you know that its indeed a healthy gateway behind it?
Member
Author
There was a problem hiding this comment.
This is hack on top of hack to try and get something working,
Will need to consolidate
HCookie
force-pushed
the
rework-testing
branch
from
3ca4c04 to
154e925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration tests
Contributor Declaration
By opening this pull request, I affirm the following: