-
Notifications
You must be signed in to change notification settings - Fork 36
Deprecate ecbuild_find_(mpi|omp).cmake macros #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR marks the legacy ecbuild_find_mpi/ecbuild_find_omp-related macros as deprecated in favor of using CMake’s built-in FindMPI and FindOpenMP, aligning with Issue #126 and the broader move away from ecbuild-specific find wrappers.
Changes:
- Updated the RST-style documentation blocks in
ecbuild_find_mpi.cmakeandecbuild_find_omp.cmaketo clearly label the affected macros as deprecated and direct users toFindMPI/FindOpenMP. - Added runtime deprecation warnings inside the MPI-related macros (
ecbuild_find_mpi,ecbuild_enable_mpi,ecbuild_include_mpi) via a new helper call at macro entry. - Added runtime deprecation warnings inside the OpenMP-related macros (
ecbuild_find_omp,ecbuild_enable_omp,ecbuild_enable_ompstubs) via a new helper call at macro entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| cmake/ecbuild_find_omp.cmake | Adds documentation and runtime deprecation for ecbuild_find_omp, ecbuild_enable_omp, and ecbuild_enable_ompstubs to steer users toward CMake’s FindOpenMP. |
| cmake/ecbuild_find_mpi.cmake | Adds documentation and runtime deprecation for ecbuild_find_mpi, ecbuild_enable_mpi, and ecbuild_include_mpi to steer users toward CMake’s FindMPI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d740be7 to
bc4c94c
Compare
Description
These changes deprecate
ecbuild_find_(mpi|omp).cmakemacros, in favour of directly usingFindMPIandFindOpenMP-- as suggested by #126.Contributor Declaration
By opening this pull request, I affirm the following: