Make line ending of generated .md5 compatible with one in the output …#30
Closed
shinji-s wants to merge 1 commit intoecmwf:developfrom
Closed
Make line ending of generated .md5 compatible with one in the output …#30shinji-s wants to merge 1 commit intoecmwf:developfrom
shinji-s wants to merge 1 commit intoecmwf:developfrom
Conversation
…of 'cmake -E md5sum' command.
|
|
Member
|
Hi Shinji, thanks for this contribution. |
tlmquintino
previously approved these changes
Sep 7, 2020
Member
tlmquintino
left a comment
tlmquintino
left a comment
There was a problem hiding this comment.
This looks like a correct change to ensure consistency in the checks across platforms.
oiffrig
previously approved these changes
Sep 9, 2020
oiffrig
dismissed stale reviews from tlmquintino and themself
The base branch was changed.
oiffrig
approved these changes
Sep 9, 2020
Collaborator
|
Merged manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…of 'cmake -E md5sum' command.
It seems configure_file() by default forces platform specific line ending in the output whereas 'cmake -E md5sum ...' emits LF regardless of the platform. That results in failure of 'cmake -E compare_files' on Windows. I think ultimately cmake should be fixed for consistent behavior but I'm afraid it's too late for that to happen. Without this patch, AppVeyor test for ecmwf/eccodes#41 fails.