Skip to content

Conversation

@iainrussell
Copy link
Member

Description

Fixes ecmwf/eccodes#372. The only change in behaviour that might not be expected is that now a developer who clones the eccodes-python repo and does pip install -e . will not get eccodeslib installed automatically - they will have to manually install it if they wish it to be there.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.01%. Comparing base (68cff89) to head (388632a).

Files with missing lines Patch % Lines
setup.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #141      +/-   ##
===========================================
- Coverage    30.03%   30.01%   -0.02%     
===========================================
  Files           34       34              
  Lines         6177     6180       +3     
  Branches       742      743       +1     
===========================================
  Hits          1855     1855              
- Misses        4293     4296       +3     
  Partials        29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shahramn shahramn self-assigned this Oct 21, 2025
@shahramn shahramn added the approved-for-ci Approved for CI label Oct 21, 2025
@iainrussell
Copy link
Member Author

OK, @shahramn, I've tested the deployment of this (platform agnostic wheels) on https://test.pypi.org/project/eccodes/#files and it looks good to me. A 'normal' install will bring in eccodeslib, and a --no-binary install will not. Feel free to merge when you're happy to do so.

@shahramn shahramn merged commit 83cf548 into develop Oct 21, 2025
138 checks passed
@shahramn shahramn deleted the fix/source-dist branch October 21, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-for-ci Approved for CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"--no-binary" does not work

4 participants