Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.26.0 #113

Merged
merged 64 commits into from
Mar 25, 2024
Merged

Version 1.26.0 #113

merged 64 commits into from
Mar 25, 2024

Conversation

pmaciel
Copy link
Member

@pmaciel pmaciel commented Mar 25, 2024

Version 1.26.0:

  • Change: Configuration deprecate access to eckit::Value
  • Change: deprecate OpenSSL (DEFAULT=OFF)
  • Change: deprecate eckit::MethodNotYetImplemented
  • Fix: several compilation warnings (GNU/Intel/PGI/NVHPC-specific, Eigen headers, unreachable statements, unused variables, deprecation
  • Fix: wrong return value in mpi::NullGroupContent::size()
  • Fix: Regex escape special chars
  • Fix: eckit::codec support for GCC 8.5
  • Fix: normalise angle performance improvement (bit-identical)
  • New: efficiently merging multiple DenseSets
  • New: qhull convex hull interfacing (eckit::maths::Qhull)

TomHodson and others added 30 commits June 27, 2023 11:16
@TomHodson
change suggested install location from ~/local to ~/.local
48044e2
@pmaciel
eckit::maths::Qhull
7835955
@pmaciel
eckit::maths::Qhull
b377e8a
@pmaciel
eckit::maths modernise
1d158eb
@pmaciel
eckit::maths minimise includes
8a18cf9
@danovaro
Merge branch 'hotfix/1.25.1' into develop
2cb0c90
@danovaro
Merge branch 'hotfix/1.25.2' into develop
a15c92c
@danovaro
Merge branch 'develop' of github.com:ecmwf/eckit into develop
11724e0
@pmaciel
eckit::maths::Qhull simplifications
3fef4c5
@pmaciel
eckit::maths::Qhull make dependency private to eckit/eckit::maths
1c0c407
@pmaciel
eckit::maths::Qhull missing check
b6d2b4f
@simondsmart
Add support for efficiently merging multiple DenseSets
f3050e2
@simondsmart
Merge branch 'develop' of ssh://github.com/ecmwf/eckit into develop
f6a1778
@pmaciel
eckit::maths::Qhull replace list_triangles for list_facets(size_t)
1c9b7d6
@pmaciel
eckit::maths::Qhull std::move semantics
e30cf5d
@simondsmart
Insertion of values to DenseSet should not make set unsorted unless o…
fd87a92 
…ut of order
@simondsmart
Support for <h1> in Html class
33c6ab8
@pmaciel
eckit::maths::Qhull low-level access to connectivity of any size, for…
d4a5041 
… optimal building of block connectivities
@simondsmart
Fix DenseSet tests
57dea7c
@pmaciel
eckit::maths::Qhull improve square pyramid test on handling hybrid co…
0d9b4fd 
…nnectivity
@simondsmart
Add JSON output to DenseSet
1e188aa
@pmaciel
eckit::maths::ConvexHull move exceptions from maths::Qhull to maths::…
ecdea36 
…ConvexHull to be abstract from dependency
@pmaciel
eckit::maths::ConvexHull::Exception specialised exception handling
19701fe
@simondsmart
Merge pull request #75 from TomHodson/fix/change-suggested-install-lo…
e58acbf 
…cation

Fix: Change suggested install location from ~/local to ~/.local
@tlmquintino
Timer reset
547577f
@wdeconinck
Merge pull request #99 from ecmwf/feature/qhull
320627f 
Feature/qhull
@shahramn
Compiler warnings re sprintf
d8951a4
@tlmquintino
Merge pull request #109 from shahramn/develop
bdd77bb 
Compiler warnings re sprintf
@wdeconinck
Avoid warnings
a382dc0
@wdeconinck
Deprecate const Value& Configuration::get() because access to Value…
bed8b53 
… should be protected

LocalConfiguration is extended to avoid access to Value in downstream classes.
wdeconinck and others added 18 commits March 22, 2024 15:28
@wdeconinck
Disable warnings with Intel/ GNU/ NVHPC compiler in tests which are t…
e835989 
…riggered on purpose
@wdeconinck
Disable deprecation warning for Intel / GNU / NVHPC compiler on using…
2d10971 
… ::readdir_r as we are already aware
@wdeconinck
Deprecate use of eckit::MethodNotYetImplemented
3155d8c
@wdeconinck
Add [[fallthrough]] attributes in YAMLParser switch statement to avoi…
9d1870b 
…d warnings
@wdeconinck
Rename variable with name 'concept' as this is a C++20 keyword
3c404a1
@wdeconinck
Fix warning in LinearAlgebraMKL: 'type qualifiers ignored on cast res…
e6c6a65 
…ult type [-Wignored-qualifiers]'
@wdeconinck
Fix warning on including a deprecated or antiquated header in StdioBuf.h
3c31739
@wdeconinck
Avoid warnings from within Eigen headers by using SYSTEM CMake keyword
56e96c5
@wdeconinck
Fix warning of implicit conversion from 'long long' to 'double' in Fr…
b99d855 
…action.cc
@pmaciel @wdeconinck
Fix further deprecation warnings
ad06f5d
@wdeconinck
Deprecate OpenSSL (DEFAULT=OFF)
53a58bd
@wdeconinck
Remove unused variable
4ee442a
@wdeconinck
Remove unreachable statements
22a3c61
@wdeconinck
Suppress NVHPC compiler warning on unused variable in system FD_ZERO …
0a07386 
…macro
@wdeconinck
Call base class constructor in derived class
92dc9b0
@wdeconinck
Update previous PGI specific warning suppression flag for eckit_sql t…
2a5f3a0 
…o apply to NVHPC as well
@wdeconinck
Merge pull request #110
79e22ee 
Fix warnings
@pmaciel
Version 1.26.0
d979813
@pmaciel pmaciel changed the base branch from develop to master March 25, 2024 11:57
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.17170% with 236 lines in your changes are missing coverage. Please review.

Project coverage is 62.69%. Comparing base (09b1f64) to head (d979813).
Report is 154 commits behind head on master.

Files Patch % Lines
src/eckit/io/MoverTransferSelection.cc 0.00% 68 Missing ⚠️
src/eckit/net/Connector.cc 0.00% 14 Missing ⚠️
src/eckit/io/cluster/ClusterNodes.cc 0.00% 11 Missing ⚠️
src/eckit/option/FactoryOption.cc 21.42% 11 Missing ⚠️
src/eckit/option/MultiValueOption.cc 75.00% 11 Missing ⚠️
src/eckit/system/LibraryManager.cc 62.06% 11 Missing ⚠️
src/eckit/config/LocalConfiguration.cc 33.33% 10 Missing ⚠️
src/eckit/io/EasyCURL.cc 0.00% 8 Missing ⚠️
tests/option/eckit_test_option_cmdargs.cc 98.78% 8 Missing ⚠️
src/eckit/option/SimpleOption.cc 75.86% 7 Missing ⚠️
... and 32 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   62.64%   62.69%   +0.05%     
==========================================
  Files         779      790      +11     
  Lines       44303    45386    +1083     
==========================================
+ Hits        27753    28455     +702     
- Misses      16550    16931     +381

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wdeconinck
wdeconinck reviewed Mar 25, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@FussyDuck
Copy link

FussyDuck commented Mar 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pmaciel
Copy link
Member Author

pmaciel commented Mar 25, 2024

@TomHodson, @simondsmart can you please sign the CLA? Thanks!

@danovaro danovaro merged commit 3101f61 into master Mar 25, 2024
158 of 172 checks passed
@danovaro danovaro deleted the release/1.26.0 branch March 25, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdeconinck wdeconinck wdeconinck approved these changes

@simondsmart simondsmart Awaiting requested review from simondsmart

@danovaro danovaro Awaiting requested review from danovaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.