Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/local path name append #149

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

danovaro
Copy link
Member

moved from FDB

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/11823250222.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/11823275408.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 63.74%. Comparing base (c4a2cc5) to head (c74365f).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
src/eckit/filesystem/LocalPathName.cc 0.00% 10 Missing ⚠️
src/eckit/system/LibraryManager.cc 28.57% 5 Missing ⚠️
src/eckit/net/SocketOptions.cc 0.00% 4 Missing ⚠️
src/eckit/sql/expression/BitColumnExpression.h 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #149      +/-   ##
===========================================
- Coverage    63.76%   63.74%   -0.02%     
===========================================
  Files         1065     1066       +1     
  Lines        55342    55360      +18     
  Branches      4085     4086       +1     
===========================================
+ Hits         35288    35289       +1     
- Misses       20054    20071      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/11824320821.

@simondsmart simondsmart merged commit cceb069 into develop Nov 13, 2024
219 of 221 checks passed
@simondsmart simondsmart deleted the feature/localPathName_append branch November 13, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants