Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable formatting CI job #67

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

figi44
Copy link
Collaborator

@figi44 figi44 commented Apr 4, 2023

Enable CI job to run clang-format on this repository.
Format source files, excluding src/eckit/contrib directory.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.48 ⚠️

Comparison is base (51d3bf3) 62.64% compared to head (1b155a8) 62.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #67      +/-   ##
===========================================
- Coverage    62.64%   62.16%   -0.48%     
===========================================
  Files          779      784       +5     
  Lines        44303    44397      +94     
===========================================
- Hits         27752    27600     -152     
- Misses       16551    16797     +246     

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@figi44 figi44 force-pushed the feature/ci-code-formatting branch 3 times, most recently from 838f714 to 446ac25 Compare April 14, 2023 14:12
@figi44 figi44 marked this pull request as ready for review April 14, 2023 14:14
Copy link
Contributor

@simondsmart simondsmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly fine, and mostly looks good to merge it in.

However, there are some places where the formatting is a bit weird. Three in particular:

  1. It looks like some lines have been combined/fomatted to be waaaay too long (especially where there are chains of || operations). We shouldn't be modifying the code to exceed our agreed line length.
  2. The '=' alignment is being overzealous. In places it is nice, but in some cases where there is a really long line, it makes the rest look daft/unreadable. We really need to have a limit on how much this happens.
  3. Alignment of comments is normally fine. But in particular the comments after public/private in class definitions aren't comments like the rest, and don't benefit from alignment.

tests/mpi/eckit_test_mpi.cc Outdated Show resolved Hide resolved
tests/utils/test_translator.cc Outdated Show resolved Hide resolved
src/eckit/container/CacheManager.h Outdated Show resolved Hide resolved
src/eckit/container/DenseMap.h Outdated Show resolved Hide resolved
src/eckit/container/DenseMap.h Outdated Show resolved Hide resolved
src/eckit/filesystem/URI.h Outdated Show resolved Hide resolved
src/eckit/io/PeekHandle.h Outdated Show resolved Hide resolved
src/eckit/mpi/Comm.h Outdated Show resolved Hide resolved
src/eckit/system/LibraryManager.cc Outdated Show resolved Hide resolved
src/eckit/utils/ByteSwap.h Outdated Show resolved Hide resolved
@figi44 figi44 force-pushed the feature/ci-code-formatting branch from 446ac25 to fb1c3c6 Compare June 8, 2023 13:35
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Private downstream CI failed.
Workflow name: private downstream ci hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/5212517468.

@figi44 figi44 force-pushed the feature/ci-code-formatting branch from 37a726f to 1b155a8 Compare June 9, 2023 07:50
@figi44
Copy link
Collaborator Author

figi44 commented Jun 9, 2023

Reset to latest develop as all source files were formatted as part #70 and the formatting check now passes fine.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Private downstream CI failed.
Workflow name: private downstream ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/5221032381.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Private downstream CI failed.
Workflow name: private downstream ci hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/5221100793.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants