-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable formatting CI job #67
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #67 +/- ##
===========================================
- Coverage 62.64% 62.16% -0.48%
===========================================
Files 779 784 +5
Lines 44303 44397 +94
===========================================
- Hits 27752 27600 -152
- Misses 16551 16797 +246 ☔ View full report in Codecov by Sentry. |
838f714
to
446ac25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly fine, and mostly looks good to merge it in.
However, there are some places where the formatting is a bit weird. Three in particular:
- It looks like some lines have been combined/fomatted to be waaaay too long (especially where there are chains of || operations). We shouldn't be modifying the code to exceed our agreed line length.
- The '=' alignment is being overzealous. In places it is nice, but in some cases where there is a really long line, it makes the rest look daft/unreadable. We really need to have a limit on how much this happens.
- Alignment of comments is normally fine. But in particular the comments after public/private in class definitions aren't comments like the rest, and don't benefit from alignment.
446ac25
to
fb1c3c6
Compare
Private downstream CI failed. |
37a726f
to
1b155a8
Compare
Reset to latest develop as all source files were formatted as part #70 and the formatting check now passes fine. |
Private downstream CI failed. |
Private downstream CI failed. |
Enable CI job to run clang-format on this repository.
Format source files, excluding
src/eckit/contrib
directory.