[cd] allow for v1+v2 simultaneously #259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
cc @liefra |
During the wheel building, we now build both frontends and copy them into the wheel. We extend config with a frontend_version which allows to specify which is the default index.html etc at launch time. To demonstrate, try fiab__general__frontend_version=v2 python -m forecastbox.standalone.entrypoint or fiab__general__frontend_version=v1 python -m forecastbox.standalone.entrypoint Additionally there was apparently a bug in building the manifest which we fix
tmi
force-pushed
the
feat/multifrontendWheel
branch
from
d5e0301 to
6290d0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the wheel building, we now build both frontends and copy them into the wheel. We extend config with a frontend_version which allows to specify which is the default index.html etc at launch time.
To demonstrate, try
or
with a wheel built from this branch
Additionally there was apparently a bug in building the manifest which we fix