Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote protcol test #22

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Add remote protcol test #22

merged 3 commits into from
Oct 29, 2024

Conversation

ChrisspyB
Copy link
Member

No description provided.

@ChrisspyB
Copy link
Member Author

Failing for seemingly unrelated reasons involving the new scan-files tool. But why did its CI pass?

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.45%. Comparing base (f820764) to head (d029f54).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #22      +/-   ##
===========================================
+ Coverage    58.72%   61.45%   +2.72%     
===========================================
  Files           83       84       +1     
  Lines         4356     4384      +28     
  Branches       479      480       +1     
===========================================
+ Hits          2558     2694     +136     
+ Misses        1798     1690     -108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisspyB
Copy link
Member Author

Failed due to an upstream change in fdb develop. Fixed now

@ChrisspyB
Copy link
Member Author

Waiting on #23 to be merged, which includes updates to the CI to actually run the tool tests. These in turn depend on a findaec update on eckit.

@ChrisspyB ChrisspyB merged commit 585b74e into develop Oct 29, 2024
100 checks passed
@ChrisspyB ChrisspyB deleted the feature/remote-test branch October 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants