Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unique exresult #24

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Feature/unique exresult #24

merged 4 commits into from
Oct 30, 2024

Conversation

ChrisspyB
Copy link
Member

Make the ExtractionResult object non-copyable, and transfer ownership on the C-interface.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@585b74e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/gribjump/gribjump_c.cc 0.00% 7 Missing ⚠️
src/gribjump/ExtractionData.h 0.00% 1 Missing ⚠️
src/tools/gribjump-validate.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #24   +/-   ##
==========================================
  Coverage           ?   61.44%           
==========================================
  Files              ?       84           
  Lines              ?     4388           
  Branches           ?      480           
==========================================
  Hits               ?     2696           
  Misses             ?     1692           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisspyB ChrisspyB merged commit 1282899 into develop Oct 30, 2024
100 checks passed
@ChrisspyB ChrisspyB deleted the feature/unique_exresult branch October 30, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants