Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread local metrics overhaul #26

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Conversation

ChrisspyB
Copy link
Member

todo:

  • Add context to all requests
  • Add depth to axes

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 53.03030% with 62 lines in your changes missing coverage. Please review.

Project coverage is 62.05%. Comparing base (65d9010) to head (b00df78).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/gribjump/Metrics.cc 56.00% 22 Missing ⚠️
src/gribjump/remote/Request.cc 0.00% 18 Missing ⚠️
src/gribjump/remote/GribJumpUser.cc 0.00% 17 Missing ⚠️
src/gribjump/gribjump_c.cc 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #26      +/-   ##
===========================================
+ Coverage    60.89%   62.05%   +1.16%     
===========================================
  Files           85       85              
  Lines         4429     4420       -9     
  Branches       482      485       +3     
===========================================
+ Hits          2697     2743      +46     
+ Misses        1732     1677      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisspyB ChrisspyB marked this pull request as ready for review November 4, 2024 15:30
@ChrisspyB ChrisspyB merged commit b49eaca into develop Nov 4, 2024
100 checks passed
@ChrisspyB ChrisspyB deleted the feature/metrics-overhaul branch November 4, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants